Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: move xray and xray-lambda propagators to contrib #4966

Merged
merged 7 commits into from
Oct 23, 2024
Merged

chore: move xray and xray-lambda propagators to contrib #4966

merged 7 commits into from
Oct 23, 2024

Conversation

pichlermarc
Copy link
Member

Which problem is this PR solving?

  • the spec prohibits us from hosting vendor propagators in the core repo. From the spec:

Additional Propagators implementing vendor-specific protocols such as AWS
X-Ray trace header protocol MUST NOT be maintained or distributed as part of
the Core OpenTelemetry repositories.

Short description of the changes

@pichlermarc pichlermarc force-pushed the chore/move-xray-propagators branch from 90c8c31 to 40b4f95 Compare August 30, 2024 13:27
@pichlermarc pichlermarc mentioned this pull request Aug 30, 2024
Closed
@pichlermarc
Copy link
Member Author

I will take this out of draft once open-telemetry/opentelemetry-js-contrib#2411 is merged 🙂

@pichlermarc pichlermarc mentioned this pull request Oct 21, 2024
Merged
@codecov Codecov
Copy link

codecov bot commented Oct 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.17%. Comparing base (55a1fc8) to head (876ac2e).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4966      +/-   ##
==========================================
- Coverage   93.26%   93.17%   -0.10%     
==========================================
  Files         317      315       -2     
  Lines        8195     8086     -109     
  Branches     1641     1617      -24     
==========================================
- Hits         7643     7534     -109     
  Misses        552      552

@pichlermarc pichlermarc marked this pull request as ready for review October 21, 2024 13:10
@pichlermarc pichlermarc requested a review from a team as a code owner October 21, 2024 13:10
@pichlermarc pichlermarc added this pull request to the merge queue Oct 23, 2024
Merged via the queue into open-telemetry:main with commit 006fe44 Oct 23, 2024
21 checks passed
@pichlermarc pichlermarc deleted the chore/move-xray-propagators branch October 23, 2024 09:29
Annosha pushed a commit to Annosha/opentelemetry-js that referenced this pull request Nov 2, 2024
@pichlermarc @Annosha
chore: move xray and xray-lambda propagators to contrib (open-telemet…
cf4a92a 
…ry#4966)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trentm trentm trentm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pichlermarc @trentm